-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some threading issues on Darwin. #20197
Fix some threading issues on Darwin. #20197
Conversation
There were two places where we were touching SDK data structures from the wrong event queue.
PR #20197: Size comparison from 6c6dca3 to 7071652 Increases (3 builds for cc13x2_26x2, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should be introducing the idea of "Disconnecting" to a client here. Can we hide this inside somehow? Additionally, maybe there's another action this can be tied to?
Aside: Disconnect isn't the correct verb, as you're not actually disconnecting anything.
The issue is basically a test harness one: it has out-of-band knowledge that the other side rebooted and our CASE session is gone and is doing an explicit re-establish. We need to think a bit about whether we want public API for this or not and what it should look like; for now I will just stick this the same place |
PR #20197: Size comparison from 6c6dca3 to da876e2 Increases (4 builds for cc13x2_26x2, telink)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There were two places where we were touching SDK data structures from
the wrong event queue.
Problem
Doing bad things with threads.
Change overview
Make sure to queue the relevant bits to the Matter queue.
Testing
Without this, #20180 will fail CI.